fix: resolve TypeScript error and audit vulnerabilities#98
fix: resolve TypeScript error and audit vulnerabilities#98flyingsquirrel0419 wants to merge 9 commits into
Conversation
- Fix FetchRateLimiter queue generic type mismatch (TS2322) - Update lint/lint:fix scripts to use npx @biomejs/biome - Bump tmp via npm audit fix (Path Traversal GHSA-ph9p-34f9-6g65) Fixes #94, Fixes #95, Fixes #96
fix: resolve TypeScript error, lint script, and tmp vulnerability
- Fix FetchRateLimiter queue generic type mismatch (TS2322) - Update lint/lint:fix scripts to use npx @biomejs/biome - Bump tmp via npm audit fix (Path Traversal GHSA-ph9p-34f9-6g65) Fixes #94, Fixes #95, Fixes #96
|
Warning Review limit reached
More reviews will be available in 56 minutes and 1 second. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe Changes3.1.1 Release Fixes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)✅ Unit Test PR creation complete.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
turin-dev
left a comment
There was a problem hiding this comment.
Looks good overall — CI is green and the dependency update direction makes sense.
One minor issue before merge: CHANGELOG.md adds a released 3.1.1 section, but package.json and package-lock.json still say 3.1.0. If this PR is intended to be the 3.1.1 release, please bump the package version too. Otherwise, I’d keep these notes under Unreleased until the release PR.
Non-blocking: the FetchRateLimiter type fix works, but the task / resolve casts could be avoided by storing a run: () => Promise<void> closure in QueueItem, which would preserve the T relationship at enqueue time without casting resolve to accept unknown.
|
Note Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it. Generating unit tests... This may take up to 20 minutes. |
|
✅ Created PR with unit tests: #99 |
Description
This PR fixes the valid issues from the analysis pass:
FetchRateLimiter.tsunderstrictmode (TS2322)Issue #95 was verified separately and closed as invalid/not reproducible:
npm runalready resolves local binaries fromnode_modules/.bin, sobiome check .does not neednpx.Type of Change
Changes
src/internal/FetchRateLimiter.ts: Removed the generic fromQueueItem; castresolveandtaskwhen enqueuing to satisfy Promise typespackage.json: Restoredlintandlint:fixto directbiomeinvocationspackage.json: Updatedtsxto^4.22.4package.json: Added anesbuildoverride to0.28.1so transitive dev tooling no longer resolves the vulnerable0.27.xlinepackage-lock.json: Regenerated the lockfile withtmp@0.2.7,tsx@4.22.4, andesbuild@0.28.1Testing
npm audit— 0 vulnerabilitiesnpm run buildnpm run lintnpm test— 598 passed, 24 skippedNotes
GitHub may still report vulnerabilities on the default branch until this PR is merged, because the default branch lockfile still contains the old dependency graph.
Summary by CodeRabbit
Bug Fixes
Tests
Chores