fix: resolve issues 94 and 96#100
Conversation
- Fix FetchRateLimiter queue generic type mismatch (TS2322) - Update lint/lint:fix scripts to use npx @biomejs/biome - Bump tmp via npm audit fix (Path Traversal GHSA-ph9p-34f9-6g65) Fixes #94, Fixes #95, Fixes #96
fix: resolve TypeScript error, lint script, and tmp vulnerability
- Fix FetchRateLimiter queue generic type mismatch (TS2322) - Update lint/lint:fix scripts to use npx @biomejs/biome - Bump tmp via npm audit fix (Path Traversal GHSA-ph9p-34f9-6g65) Fixes #94, Fixes #95, Fixes #96
|
Warning Review limit reached
More reviews will be available in 33 minutes and 11 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe PR releases v3.1.1 by refactoring ChangesFetchRateLimiter QueueItem refactor and regression tests
Dependency updates and documentation badges
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
3-3:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winUpdate package version to 3.1.1.
The version field still shows
3.1.0, but the CHANGELOG, PR objectives, and all documentation reference v3.1.1 as the release version. Publishing without this update will create a version mismatch.📦 Proposed fix
- "version": "3.1.0", + "version": "3.1.1",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` at line 3, Update the version field in package.json from "3.1.0" to "3.1.1" to align with the CHANGELOG, PR objectives, and documentation. This will ensure consistency across all release artifacts and prevent version mismatches when publishing.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@package.json`:
- Line 3: Update the version field in package.json from "3.1.0" to "3.1.1" to
align with the CHANGELOG, PR objectives, and documentation. This will ensure
consistency across all release artifacts and prevent version mismatches when
publishing.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4cc14909-a7d9-4d2e-81df-145982916ea4
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (9)
CHANGELOG.mdREADME.mddocs/i18n/README.es.mddocs/i18n/README.ja.mddocs/i18n/README.ko.mddocs/i18n/README.zh-CN.mdpackage.jsonsrc/internal/FetchRateLimiter.tstests/internal/FetchRateLimiter.test.ts
Description
This PR fixes the valid issues from the analysis pass:
FetchRateLimiter.tsunderstrictmode (TS2322)Issue #95 was verified separately and closed as invalid/not reproducible:
npm runalready resolves local binaries fromnode_modules/.bin, sobiome check .does not neednpx.Changes
src/internal/FetchRateLimiter.ts: removes the generic queue item mismatch and stores arun()closure so the task result type stays bound to its Promise resolver without unsafe casts.package.json: restoreslintandlint:fixto directbiomeinvocations.package.json: updatestsxto^4.22.4and adds anesbuildoverride to0.28.1.package-lock.json: regenerates the lockfile withtmp@0.2.7,tsx@4.22.4, andesbuild@0.28.1.CHANGELOG.mdand README files: document the 3.1.1 fixes and update the test baseline to 601 passing tests.tests/internal/FetchRateLimiter.test.ts: adds regression coverage for rejected queued tasks continuing to drain and defensive cleanup of corrupted pending queues.Testing
npm audit— 0 vulnerabilitiesnpm run buildnpm run lintnpm test— 601 passed, 24 skippednpm run test:coverage— 97.13% statement coverageNotes
GitHub may still report vulnerabilities on the default branch until this PR is merged, because the default branch lockfile still contains the old dependency graph.
Summary by CodeRabbit
Release Notes
Bug Fixes
Security
Tests