Repository navigation
chore: refresh dependencies and pre-commit hooks (v0.64.0) - #168
Merged
Merged
Conversation
uv lock --upgrade (51 packages, including duckdb 2.0.0, anthropic 2.11.0, sqlglot 30.33.0) and prek auto-update (ruff 0.17.6, ty 0.0.107). No declared floor moves; the lowest-floor suite passes on 3.12 and 3.13. DuckDB 2.0 holds ~50 native threads per open connection. Test fixtures never closed their adapters, so the suite hit macOS's 4096-thread cap and failed with "can't start new thread"; an autouse fixture now closes every connection a test opens. DuckDB 2.0 no longer estimates a plan root below 1 row, so the revenue example's inspect_query line changes from rows: 0 to rows: 1. mermaid-joinpath-eval is upgraded separately (37 tests pass); dabstep-contract-eval takes only the self version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
elapsed_seconds and seconds_remaining round to 0.0 locally but crossed 0.05s on a CI runner, failing the byte-for-byte diff. Scrub them in both the CI step and scripts/regen_examples.sh; retries_remaining and the token and cost budgets stay diffed exactly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From the code review of #168: - DuckDBAdapter gains close() (takes _lock, idempotent) and context-manager support. Under DuckDB 2.0 an open connection holds ~50 native threads; the CHANGELOG previously told users to reach into adapter.connection. - The examples scrub moves to scripts/scrub_example_output.py, used by CI and regen_examples.sh alike. seconds_remaining is rounded to whole seconds instead of masked, so the configured max_duration_seconds is still diffed; negative values are handled; regen uses mktemp. - The two module-scoped DuckDB fixtures close their own connections (the autouse fixture starts after them); conftest docstring says so. - CHANGELOG no longer names hook versions (CLAUDE.md rule). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From the second code review of #168: - The revenue example prints one session report as a Python dict, which the double-quote-only scrub missed, so the examples job could still flake on timing. Keys now match in either quote style. - seconds_remaining is written as <budget>-T, the budget recovered as elapsed + remaining from the same report, instead of rounded to whole seconds, which failed once a session passed ~0.5s. Verified with a fake clock at up to 3.3s elapsed. - close() docs: from async code, await asyncio.to_thread(adapter.close). - CHANGELOG no longer credits #167's ty-ignore edits to this release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… limits From the third code review of #168: - The "Sample database created at" scrub also removes a last line with no trailing newline, as the sed rule it replaced did. - The scrubber docstring states that the budget is recovered to the whole second, the precision the two 0.1s-rounded values allow. - conftest: a connection meant to outlive the test is closed too. Declined: a closed adapter's explain() reporting schema_valid=False. The agent sees "Connection already closed", and use after close is a host bug. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv lock --upgrade: 51 packages, including the major versions duckdb 2.0.0, anthropic 2.11.0, logfire-api 6.0.0 and websockets 17.4, plus sqlglot 30.33.0, pydantic-ai-slim 2.71.0, langchain-core 1.8.3 and claude-agent-sdk 0.2.185. No declared floor moves.prek auto-update: ruff 0.17.6, ty 0.0.107.mermaid-joinpath-evalupgraded (37 tests pass).dabstep-contract-evaltakes only the self version, and its frozen contract directories are untouched.Fixes the upgrade needed
RuntimeError: can't start new thread. An autouse fixture intests/conftest.pynow closes everyduckdb.connecta test makes. The suite ends at 1 thread.inspect_queryrows0->1. DuckDB 2.0's root-node cardinality estimate is never below 1 (the query actually returns 3 rows). The parser is unchanged.elapsed_seconds/seconds_remaining(CI step andscripts/regen_examples.sh). These wall-clock values round to 0.0 locally (10–32 ms measured under both DuckDB versions) but crossed 0.05 s on the first CI run of this PR.retries_remainingand the token and cost budgets are still diffed exactly.Test plan
prek run --all-filesuv run pytest(3,257 passed)uvx uv-secure uv.lock: cleanuv lock --check🤖 Generated with Claude Code