Repository navigation
fix: status CPU reports the whole serve process tree - #354
Merged
Merged
Conversation
The snapshot measured the serve process alone (ProcessesToUpdate::Some(&[pid])) — during a rebuild wave the scip-csharp helper and its dotnet children do the heavy lifting, so the reported CPU read near-zero exactly when the machine was busy. The snapshot now refreshes all processes once (so parent links are populated), walks the serve process's descendant tree and sums the per-process usage, normalized against the core count as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status snapshot measured the serve process alone (
ProcessesToUpdate::Some(&[pid])) — during a rebuild wave the scip-csharp helper and its dotnet children do the heavy lifting, so the reported CPU read near-zero exactly when the machine was busy.The snapshot now refreshes all processes once (so parent links are populated), walks the serve process's descendant tree (platform-independent via
Process::parent()) and sums the per-process usage, normalized against the core count as before. Samecpu_percentfield and format — the remote TUI and MCP clients see the honest number without any contract change.Validation: fmt, clippy
--all-targets -D warnings,cargo test --lib --bins+ fullcargo test --test '*'green; the two snapshot handler tests pass unchanged.