Repository navigation
fix: wrap the watcher include-test fixture literal with an escape - #351
Merged
Merged
Conversation
The .codesearchinclude fixture was written as a real multi-line string literal — the caller-facing-literals detector (tests/caller_facing_literals.rs, run by CI's cargo test --test '*') flags any literal spanning lines without a \ continuation, on every platform. Local validation missed it because it only ran --lib --bins; the integration tests never ran before push. Full --test '*' suite now green locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI failed on all three platforms (
test-windows,test-linux,csharp-integration-tests) with exactly one real failure:no_source_literal_was_wrapped_without_a_continuation— the.codesearchincludefixture in the watcher include-gate test was written as a real multi-line string literal, which the caller-facing-literals detector flags (literals spanning lines need a\continuation).Everything else in the failing run was noise: the lib suites passed everywhere (937 passed in the csharp job); the
embed::cachepanic line in the log is the test's own simulated panic undercatch_unwind, printed by--nocapture— the test passed.Process note: local validation and the pre-push QC gate only run
--lib --bins; thetests/integration suite never ran before push. This fix was verified with the fullcargo test --test '*'locally (all suites green, INTEG_EXIT:0).