Repository navigation
test: final-sweep remarks — model-gate refusal pin, include-test isolation, comment fix - #350
Merged
Merged
Conversation
…ation, comment fix Final full review (eef179a..8f0b79c) verdict PASS WITH REMARKS; the three actionable findings: - the no-download model gate's search-path refusal had no test the suite reaches (the pool-layer pins are #[ignore]-gated): a hermetic serve test now pins that a semantic search with an empty model cache answers the explicit refusal naming 'codesearch setup' instead of fetching. - the six include-gate tests walked tempdirs without the #[serial] + isolated-home guard their siblings got (6ba0778) — a developer's global .codesearchignore could prune the fixtures and redden the suite. All six now isolated. - parse_import_lines' comment still taught the 0-based premise the reconciliation removed; reworded to the shipped 1-based convention. The two [Design] rows (literal_search size, semantic_search_multi interning dance) are deferred — recorded here, no action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final full review over this session's merged range (
eef179a..8f0b79c, 7 PRs) returned PASS WITH REMARKS — no Critical, all five requirements verified against load-bearing code, and a fresh enumeration confirming the +1 line-convention class is fully closed (only the two deliberate producer-side sites remain). This PR lands the three actionable remarks:#[ignore]-gated; the timeout branch is untestable hermetically). New hermetic serve test: emptyCODESEARCH_HOMEmodel cache → semantic search answers the explicit refusal namingcodesearch setupinstead of turning the query into a network fetch — the whole-night serve stall the gate exists to prevent.#[serial]+ isolated-home guard their siblings got (commit 6ba0778 proved the developer's global.codesearchignoreleaks into walker/watcher tests). All six now isolated — the identical incident this range already fixed once, re-created on the newer tests.parse_import_lines' comment still taught the 0-based premise the line-convention reconciliation removed — reworded to the shipped 1-based convention (the exact misreading that produced the round-2 +1 regression).The two [Design] rows (literal_search's 631 lines, semantic_search_multi's interning dance) are deferred and recorded in the commit message.
Validation: fmt clean, clippy
--all-targets -D warningsclean,cargo test --lib --bins942 passed / 0 failed.