Repository navigation
fix: strip the five surviving +1 emit sites (literal search, imports) - #348
Merged
Merged
Conversation
Round-2 review of the line-convention reconciliation counted 27 PR-added emit sites, not 22: four literal-search match-line compositions and the imports helper still reported line N as N+1. True editor line is start_line + offset (offset is 0-based within the chunk content); the emitted start_line + offset + 1 was true + 1. - literal_search.rs x4 + mcp/mod.rs imports helper: +1 stripped - test_parse_import_lines_detects_common_forms: premise + expected values corrected to the shipped convention (10-14, was 11-15) - two stale comments refreshed (search.rs emit, relaxed-fallback test fixture moved to a 1-based chunk) Review deviation: the 2-round cap was reached (round 2 FAIL on the incomplete sweep); the reviewer's fix list is mechanical and was executed verbatim, then self-verified read-only — full sweep re-run shows only producer-side +1 sites remain (jupyter chunker, scip_proto), plus fmt/clippy/939 tests green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes PR #347: the round-2 review counted 27 PR-added
+1emit sites, not 22 — four literal-search match-line compositions (literal_search.rs:138,192,426,509) and the imports helper (mcp/mod.rs:980) survived outside the first sweep, so literal match lines and graph-import responses still reported line N as N+1.True editor line =
start_line + offset(offset is 0-based within the chunk content); the emittedstart_line + offset + 1was true + 1.+1s stripped.test_parse_import_lines_detects_common_forms: premise + expected values corrected to the shipped convention (10–14, was 11–15) — it was the last green test pinning the dead convention.Review-process note: the 2-round cap was reached (round 2 FAIL on the incomplete sweep). The reviewer's fix list is mechanical, was executed verbatim, and was self-verified read-only: a full re-sweep shows only producer-side
+1sites remain (jupyter chunker, scip_proto — both deliberate convention conversions), and fmt / clippy--all-targets -D warnings/cargo test --lib --bins(939 tests) are fully green.