Repository navigation
perf(scip-csharp): precompute C# references at index build - #341
Merged
Merged
Conversation
The rebuild is about to absorb the reference pass; per-stage [TIMING] lines (msbuild register, workspace open, compile, definitions, output) show where a cold rebuild spends its time before and after.
References are collected during the single symbol walk instead of a per-symbol FindReferences pass. Index 2.1 carries them precomputed; parity tests pin the output to the per-symbol results.
Rebuild reads the references shipped by scip-csharp index 2.1 into scip_ref_cache and stamps refs_coverage, so find_impact no longer needs a helper run per request. Prewarm skips covered workspaces; the workspace idle timeout rises to 3600s to keep them warm.
…ume guard Roslyn reports zero references for query clauses and 2 for event += / -=; pin that behaviour. The volume guard pins the N x M cascade fan-out to FindReferencesAsync (measured 80k refs / 25 MB on a 13-project solution).
The change is user-visible and the require-changelog check blocks PR #341 without an entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: C# find_impact paid the full reference cost per request. Measured on a 13-project workspace: 80k refs, 25 MB JSON, 31 s cold. This emits references in one scip-csharp pass and ingests them at rebuild. Gaps pinned in tests (oversized precomputed key, restore-pending state, query-clause and event parity). Not yet deployed.