Skip to content

fix: diff-review findings (symbol pairing, noise, FTS scope, atomic save, rebuild guard) - #338

Merged
flupkede merged 3 commits into
developfrom
fix/review-findings-2026-10
Oct 15, 2026
Merged

flupkede merged 3 commits into
developfrom
fix/review-findings-2026-10

Conversation

@flupkede

Copy link
Copy Markdown
Owner

Fixes from the diff review of the last week's changes.

  • C# reference resolver: exact-signature pick across projects sharing an assembly name, INFO log on detached fallback
  • Missing NuGet packages stay a warning; only service-index noise is demoted
  • FTS transient retry scoped to FTS commit failures
  • file-meta save: bounded rename retry, stale tmp removed on final failure
  • One per-repo guard serializes the incremental, restore-input and branch-change symbol rebuilds
  • helper --version runs outside the helper_path lock
  • Test pins restore-pending exit code parity between Rust and the C# helper
  • CHANGELOG: find_impact position misses return an error with a hint

🤖 Generated with Claude Code

…atomic save, rebuild guard)

Narrower classifiers and bounded retries instead of broad matches or silent fallbacks; per-repo guard so the two C# flushes never rebuild one db at once.
… guard

Two full rebuilds on one LMDB db must not overlap; the branch-change task now takes the same guard as the incremental and restore-input flushes.
@flupkede
flupkede merged commit 621a98b into develop Oct 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant