Resolve #2734: Reject managed SSE without response stream support#2760
Merged
ayden94 merged 1 commit intoJul 14, 2026
Merged
Conversation
Managed SSE async iterables were silently reported as handled when the active adapter exposed no FrameworkResponse.stream, swallowing the requested event stream without an observable error. The dispatcher now checks stream support before constructing SseResponse and throws a clear unsupported-stream failure that flows through the standard dispatch error path (request error observers and the error response writer), aligning managed SSE with the documented adapter contract. - Move stream check before SseResponse construction in writeManagedSseIterable and throw instead of returning true - Add regression test covering the no-stream managed SSE path - Document the stream support requirement in README and README.ko.md - Add @fluojs/http patch changeset
ayden94
deleted the
issue-2734-reject-managed-sse-without-response-stream-support
branch
July 14, 2026 01:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Managed SSE async iterables were silently reported as handled when the active adapter exposed no
FrameworkResponse.stream, swallowing the requested event stream without an observable error. This aligns managed SSE with the documented adapter contract by surfacing a clear unsupported-stream failure before marking the response handled.Linked context: Closes #2734
Changes
packages/http/src/dispatch/dispatcher.ts:writeManagedSseIterablenow checksrequestContext.response.streambefore constructingSseResponseand throwsManaged SSE requires adapter-provided response.stream support.instead of returningtrue(silent handling). The failure flows through the standard dispatch error path (request error observers and the configured error response writer).packages/http/src/dispatch/dispatcher.test.ts: Added regression testrejects managed SSE AsyncIterable sources when the adapter exposes no response streamasserting the dispatcher commits a 500 response and notifies request error observers with the unsupported-stream message.packages/http/README.md/packages/http/README.ko.md: Documented that managed SSE requires an adapter that exposesFrameworkResponse.streamand that the dispatcher rejects the managed async iterable before marking the response handled when stream support is absent..changeset/issue-2734-reject-managed-sse-without-stream.md:@fluojs/httppatch changeset.Testing
pnpm --filter @fluojs/http typecheck— passed.pnpm --filter @fluojs/http test— 223 tests passed (83 dispatcher tests including the new regression test).pnpm verify:platform-consistency-governance— passed.pnpm verify:public-export-tsdoc(changed mode) — passed.Release impact
Public export documentation
Behavioral contract
Platform consistency governance (SSOT)