Fix horizontal scroll area

[sineme]

fixes #157, #159 and #164

The scroll area was using cachedSize for its output rectangle capping it at the screen width. As the "Work"-tab window is not always as wide as the screen, ouput rectangle was too wide when there were many work types.

To fix this the PawnTable was extended with the property methods

• void set_OutRect(this PawnTable, Rect)
• Rect get_OutRect()

'fake adding' a new property that can be used to set and get the "Work"-tab window dimension instead of relying on the screen size.

MainTabWindow_WorkTab.DoWindowContents calls set_OutRect with the window dimension

public override void DoWindowContents(Rect rect) {
    Instance.Table.set_OutRect(rect);
    ...
}

and PawnTable_PawnTableOnGUI.PawnTableOnGUI calls get_OutRect to clamp the output rectangle properly

public static bool Prefix(PawnTable __instance,
                                   Vector2 position,
                                   PawnTableDef ___def,
                                   ref Vector2 ___scrollPosition)
//harmony 1.2.0.1 gives access to private fields by ___name.
{
    ...
    var outRect = __instance.get_OutRect();
    float outWidth   = outRect.width - labelWidth;
    ...
}

I think ideally PawnTable.PawnTableOnGUI's parameter would be Rect window instead of Vector2 position in the future.

[JiaRG]

The paste button of the last column does not appear when the column is expanded.
My current approach:

           ...
            var outRect = __instance.get_OutRect();
            float outWidth = outRect.width - labelWidth;
            float viewWidth = cachedSize.x - labelWidth;
            if (cachedSize.x < UI.screenWidth)
            {
                viewWidth -= 16f;
            }
           ...
            // increase height of table to accomodate scrollbar if necessary and possible.
            if (viewWidth > outWidth && cachedSize.y + 16f < UI.screenHeight)
            {
                // NOTE: this is probably optimistic about the available height, but it appears to be what vanilla uses.
                tableOutRect.height += 16f;
                viewWidth += 16f;
            }
            // Check if the table's height exceeds the screen height.  53: MainTabWindow_WorkTab.ExtraBottomSpace  16: horizontal scrollbar
            if (cachedHeightNoScrollbar + MainButtonDef.ButtonHeight + Constants.PriorityLabelSize.y + 53 + 16 > UI.screenHeight)
            {
                tableOutRect.width += 16f;
            }

Is there a better way to deal with this?