gem: add win32-registry as runtime dependency for Ruby 4.1#5308
Merged
kenhys merged 1 commit intofluent:masterfrom Mar 31, 2026
Merged
gem: add win32-registry as runtime dependency for Ruby 4.1#5308kenhys merged 1 commit intofluent:masterfrom
kenhys merged 1 commit intofluent:masterfrom
Conversation
Watson1978
force-pushed
the
win32-registry
branch
from
368a745 to
2e37aad
Compare
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
win32-registry
branch
from
2e37aad to
1dcac8a
Compare
Watson1978
added
the
backport to v1.19
kenhys
approved these changes
Mar 31, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Apr 5, 2026
**Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: `win32-registry` gem will be moved from default to bundled gem at Ruby 4.1. Ref. ruby/ruby#16189 Therefore, if we do not add it as a runtime dependency, it will fail to load. See https://github.com/fluent/fluentd/actions/runs/23711126803/job/69070953279 ``` Error: -03-29 14:45:48 +0000 [error]: cannot load such file -- win32/registry path=\"win32/registry\" error_class=LoadError error=\"cannot load such file -- win32/registry\"\r\n"> was expected to include: <["#0 fluentd worker is now running worker=0", "#1 fluentd worker is now running worker=1", "#1 adding match pattern=\"dummy\" type=\"null\""]> D:/a/fluentd/fluentd/test/command/test_fluentd.rb:219:in 'TestFluentdCommand#assert_log_matches' D:/a/fluentd/fluentd/test/command/test_fluentd.rb:1077:in 'block (2 levels) in <class:TestFluentdCommand>' ``` **Docs Changes**: N/A **Release Note**: * gem: add win32-registry as runtime dependency for Ruby 4.1 Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Watson1978
added a commit
that referenced
this pull request
Apr 5, 2026
…by 4.1 (#5308) (#5317) **Which issue(s) this PR fixes**: Backport #5308 Fixes # **What this PR does / why we need it**: `win32-registry` gem will be moved from default to bundled gem at Ruby 4.1. Ref. ruby/ruby#16189 Therefore, if we do not add it as a runtime dependency, it will fail to load. See https://github.com/fluent/fluentd/actions/runs/23711126803/job/69070953279 ``` Error: -03-29 14:45:48 +0000 [error]: cannot load such file -- win32/registry path=\"win32/registry\" error_class=LoadError error=\"cannot load such file -- win32/registry\"\r\n"> was expected to include: <["#0 fluentd worker is now running worker=0", "#1 fluentd worker is now running worker=1", "#1 adding match pattern=\"dummy\" type=\"null\""]> D:/a/fluentd/fluentd/test/command/test_fluentd.rb:219:in 'TestFluentdCommand#assert_log_matches' D:/a/fluentd/fluentd/test/command/test_fluentd.rb:1077:in 'block (2 levels) in <class:TestFluentdCommand>' ``` **Docs Changes**: N/A **Release Note**: * gem: add win32-registry as runtime dependency for Ruby 4.1 Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shizuo Fujita <fujita@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
win32-registrygem will be moved from default to bundled gem at Ruby 4.1.Ref. ruby/ruby#16189
Therefore, if we do not add it as a runtime dependency, it will fail to load.
See https://github.com/fluent/fluentd/actions/runs/23711126803/job/69070953279
Docs Changes:
N/A
Release Note: