Declare the service name of oidc:discover as explicitly nullable - #73
Merged
Merged
Conversation
The optional service name of the discover command is now declared as ?string. Loading the command controller no longer triggers a deprecation notice on PHP 8.4 and later. Previously, the parameter was declared as "string $serviceName = null". PHP 8.4 deprecates marking a parameter as nullable only through a null default. The notice appeared whenever Flow reflected the command, for example when rendering "./flow help", and error trackers like Sentry reported it as an issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optional
$serviceNameparameter ofOidcCommandController::discoverCommand()is now declared as?string.With PHP 8.4,
string $serviceName = nulltriggers "Implicitly marking parameter $serviceName as nullable is deprecated". Flow reflects all command controllers, for example when rendering./flow help, so the notice showed up in every installation running PHP 8.4 or later and was reported by error trackers. This was the only implicitly nullable parameter in the package; linting all classes with PHP 8.4 reports no further deprecations.?stringis supported by all PHP versions the package allows, so the change is backwards compatible.