Chrome's FileSystem API has a bug reading files from dropped folders or input dialog's selected folder#301
Open
vsta wants to merge 6 commits intoflowjs:masterfrom
Open
Chrome's FileSystem API has a bug reading files from dropped folders or input dialog's selected folder#301vsta wants to merge 6 commits intoflowjs:masterfrom
vsta wants to merge 6 commits intoflowjs:masterfrom
Conversation
… bug that files from dropped folders or files from input dialog's selected folder, with read errors (has absolute paths which exceed 260 chars) will have zero file size. When dropped folder has any file with absolute paths which exceeds 260 chars, upload should report read errors. When input dialog is used to select folder, files with absolute paths which exceeds 260 chars, will be uploaded with zero length. These files should not be uploaded, it should report read errors.
drzraf
requested changes
Sep 12, 2020
| */ | ||
| webkitReadDataTransfer: function (event) { | ||
| var $ = this; | ||
| var queue = event.dataTransfer.items.length; |
Collaborator
There was a problem hiding this comment.
It's unlikely such a huge diff (+149 −52) could be efficiently reviewed. Could you provide a minimum testcase (in the test folder) and a less intrusive bugfix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome 83.0.4103.61, Windows 10.0.18362 Chrome's FileSystem API has a bug that files from dropped folders or files from input dialog's selected folder, with read errors (has absolute paths which exceed 260 chars) will have zero file size.
When dropped folder has any file with absolute paths which exceeds 260 chars, upload should report read errors.
When input dialog is used to select folder, files with absolute paths which exceeds 260 chars, will be uploaded with zero length. These files should not be uploaded, it should report read errors.
Firefox 76.0.1, Windows 10.0.18362 doesn't have this bug, but it will not upload files with absolute path which exceeds 260 chars.
Edge 44.18362.449.0, Windows 10.0.18362 uploads all files regardless of the absolute path length.