Conversation
…ynomial_fit, leaving method stubs behind so everything is backwards compatible. The tests still pass without modification, importing from the old places.
… changed name of the general finite_difference function to be finitediff so it doesn't collide with the module name, updated the basic usage notebook to be more in line with the new structure, reran everything
pavelkomarov
commented
Aug 15, 2025
| evaluate | ||
| ======== | ||
|
|
||
| .. currentmodule:: pynumdiff.utils.evaluate |
Collaborator
Author
There was a problem hiding this comment.
This is redundant with automobile.
pavelkomarov
commented
Aug 15, 2025
| from warnings import warn | ||
|
|
||
| from pynumdiff.finite_difference import first_order as finite_difference | ||
| from pynumdiff.finite_difference import second_order as finite_difference |
Collaborator
Author
There was a problem hiding this comment.
A last case where the former-first-order-which-was-actually-second-order was still being imported as first order, which is now properly first order. I haven't been checking on lineardiff as closely, so this slipped through.
pavelkomarov
commented
Aug 15, 2025
| scipy.signal.savgol_filter. The Savitzky-Golay is very similar to the sliding polynomial fit, | ||
| but slightly noisier, and much faster. | ||
| def savgoldiff(*args, **kwargs): | ||
| warn("`savgoldiff` has moved to `polynomial_fit.savgoldiff` and will be removed from " |
Collaborator
Author
There was a problem hiding this comment.
This is just a common pattern to make the functions still importable from the old place, for backwards compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moved
splinediff,polydiff, andsavgoldiffto a new module calledpolynomial_fit, leaving method stubs behind so everything is backwards compatible. The tests still pass without modification, importing from the old places.This addresses the lion's share of #138.