Skip to content

Comments

using even fancier pytest fixtures to help localize errors#101

Merged
pavelkomarov merged 3 commits intomasterfrom
fiddle-with-test-limits
Jun 24, 2025
Merged

using even fancier pytest fixtures to help localize errors#101
pavelkomarov merged 3 commits intomasterfrom
fiddle-with-test-limits

Conversation

@pavelkomarov
Copy link
Collaborator

I broke the build, which won't do. Trying to fix it.

@pavelkomarov
Copy link
Collaborator Author

pavelkomarov commented Jun 24, 2025

My last one had the real crux lines commented out accidentally, and when I uncommented them I broke the build on master, because it turns out the cloud runs are numerically just a little different than my local runs, so a couple ended up exceeding the limits. Merging this to fix master.

This one also makes the pytest fixtures more sophisticated so we can better localize these kinds of errors in the future. That necessitated getting more sophisticated about how the code does plotting too, but the end result is somewhat cleaner than before. 🎉

@pavelkomarov pavelkomarov merged commit 14751af into master Jun 24, 2025
1 check passed
[(-25, -25), (2, 2), (0, 0), (2, 2)],
[(-25, -25), (3, 3), (0, 0), (3, 3)]],
iterated_first_order: [[(-7, -7), (-10, -11), (0, -1), (0, 0)],
iterated_first_order: [[(-7, -7), (-9, -10), (0, -1), (0, 0)],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are what I had to loosen. Unfortunately I couldn't figure out which among the sea of numbers I had to increment, so now I mark.parametrize over the test functions too.

@pavelkomarov pavelkomarov deleted the fiddle-with-test-limits branch June 24, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant