Don't consume keyboard events if mouse is over imgui window#575
Draft
sjml wants to merge 1 commit into
Draft
Conversation
Owner
|
Ah interesting, I stumbled over a similar problem a few weeks ago in my visual6502remix project, and I worked around that outside of sokol_imgui.h by ignoring the return value of I need to think about this a bit more, but what's clear is that the current behaviour in simgui_handle_event() is too hardwired. Thanks for the PR! I probably won't merge it as is, but I'll keep it open as reminder. |
Contributor
Author
Sounds good! I didn't have any particular attachment to this solution, but glad it can be a useful nudge towards future improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating an interface with Dear ImGui that only uses the mouse, I found I couldn't dismiss it with my designated toggle key because
simgui_handle_eventwas returningtrueif the mouse pointer was positioned inside one of the rendered windows. I figure that if Dear ImGui'sWantCaptureKeyboardflag isfalse, thensimgui_handle_eventshould not returntruefor keyboard events.This may be an intentional design thing, though... I'm still getting used to using Dear ImGui and maybe this is expected behavior. It felt like a bug to me, though. Even if it's something to be fixed, this might be a too ham-fisted way of going about it. (It works for my very limited case, though.)
Anyway, wanted to submit this just in case someone else gets puzzled by it as well.