impl NSTextInputClient#542
Draft
Hperigo wants to merge 2 commits into
Draft
Conversation
Owner
|
I need to read up on the macOS APIs to provide better feedback, but one dangerous thing I noticed while looking through the changes is that your PR undoes the following bug fix: Not sure how this can happen TBH. |
Owner
|
(I changed the PR to a draft so that I don't accidentally click the merge button) |
Author
|
I'll double check the please feel free to provide any other feedback =) |
|
I changed #460 because it is not working on Linux (Ubuntu 20.04.3 LTS) too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the PR implements the NSTextInputClient ( #460 ) for
MTKViewandNSOpenGLView, this will allow_sapp_macos_appto receive key code for characters likeá, é, í, ó, úa couple of notes:
_sapp.event.char_codeis set insideinsertTextmethod._sapp.event.modifiersand_sapp.event.key_repeatare still insidekeyDownI'm not sure if this is going to break something, but it looks correct.firstRectForCharacterRangeis returningreturn NSMakeRect(0.0, 0.0, 0.0, 0.0);. the original impl uses the window bounds, I'm not sure what is the difference here..This is my first PR here, so feel free to point any corrections, etc.. =)