[WIP] sokol-spritebatch sample#92
Conversation
floooh
left a comment
floooh
left a comment
There was a problem hiding this comment.
Some things I stumbled over on macOS
|
Tried testing it on sapp-webgl2-wasm-ninja-release to no avail, boo! Everything else works but my sample is a black page with no content. |
|
Here are two patch files with my changes to make emscripen work (using sokol_fetch.h instead of stbi_load(). The second wraps
|
…into spritebatch
|
I'm seeing an error and a couple of warnings on macOS with Xcode, the error is in GridVania.h, which is too big for the github review tool: The error is: ...the first 'non-static declaration' is here (line 314): extern const LDtkProject LDtkGridVania;...and the second declaration is here (line 20395): static const LDtkProject LDtkGridVania = { 0x132A3FFF, LDtkLevels, 19, LDtkTilesets, 2, 256, 256, LDtkWorldLayout_GridVania };Replacing the For the warnings I'll add regular review comments :) |
|
There's also one unused function warning in sokol_spritebatch.h (_sbatch_matmul), I'll add a review comment there. |
| .position = { | ||
| .x = xOffset + (float)tile->px.x, | ||
| .y = yOffset + (float)tile->px.y }, | ||
| .flags = tile->f, |
There was a problem hiding this comment.
"Implicit conversion changes signedness" (.flags = tile-f)
| .position = { | ||
| .x = xOffset + (float)tile->px.x, | ||
| .y = yOffset + (float)tile->px.y }, | ||
| .flags = tile->f, |
There was a problem hiding this comment.
"Implicit conversion changes signedness" (.flags = tile-f)
| .position = { | ||
| .x = xOffset + (float)tile->px.x, | ||
| .y = yOffset + (float)tile->px.y }, | ||
| .flags = tile->f, |
There was a problem hiding this comment.
"Implicit conversion changes signedness" (.flags = tile-f)
| void handle_key_press(size_t index) { | ||
| const size_t level_index = index - 1; | ||
| if (LDtkGridVania.levels[state.selected_level].neighboursLength >= index) { | ||
| state.selected_level = LDtkGridVania.levels[state.selected_level].neighbours[level_index].levelIndex; |
There was a problem hiding this comment.
"Implicit conversion changes signedness" (state.selected_level = ...)
| }); | ||
|
|
||
| sdtx_pos(screen_space.x / 8.0f, screen_space.y / 8.0f); | ||
| sdtx_printf(level->identifier.data); |
There was a problem hiding this comment.
"Format string is not a string literal (potentially insecure)"
Replace with: sdtx_printf("%s", level->identifier.data);
2 participants
Creating a sample to demonstrate sokol-spritebatch.
Sample video