Open
Conversation
GHC (and possibly other plugins) can inject synthetic imports for e.g. Backpack signatures that a module transitively depends on. Before this change, it was not possible to write a qualification rule for a signature in some circumstances, e.g. when a module that imports a signature directly is imported in a module that doesn't direclty import the signature.
GHC wants a type signature for it otherwise because we use -Wmonomorphism-restriction. Simpler to inline.
Member
Author
|
For posterity @telser and I had a conversation out-of-band about whether this would affect implicit Prelude imports (custom or otherwise) in some way and the answer is no, they do not get filtered by this function because GHC assigns them a span (line 1). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHC (and possibly other plugins) can inject synthetic imports for e.g. Backpack signatures that a module transitively depends on. Before this change, it was not possible to write a qualification rule for a signature in some circumstances, e.g. when a module that imports a signature directly is imported in a module that doesn't directly import the signature.
I created a minimal reproducer of the specific issue I ran into: https://github.com/jlavelle/henforcer-backpack-reproducer. It will fail on main, and succeed on the
with-fixbranch (which points at this commit).