Split Docker toolchain stage and make entrypoint overridable#92
Open
nitroxit wants to merge 1 commit into
Open
Split Docker toolchain stage and make entrypoint overridable#92nitroxit wants to merge 1 commit into
nitroxit wants to merge 1 commit into
Conversation
Yury-MonZon
reviewed
Jun 30, 2026
| exec "$@" | ||
| fi | ||
|
|
||
| ./build-uboot.sh |
Contributor
There was a problem hiding this comment.
Small correction on the signal reasoning here: not exec-ing these doesn't orphan the build. Bash is waiting on each script as a foreground process, so a docker stop still tears the child down - it doesn't get abandoned.
Bash won't fire a trap until the current command returns and it won't reap zombies. If we want an instant, clean stop, simplest is docker run --init. Or maybe trap + background + wait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bashor individual build scriptsCloses #77
Closes #78
Testing
git diff --cached --checkdocker build --check .docker build --target toolchain -t flipperone-toolchain:test .docker build --progress=plain -t flipperone-linux-build-scripts:test .docker run --rm flipperone-linux-build-scripts:test bash -lc "echo override-ok; test -f ./build-uboot.sh"override-okand exited with status0