Support to build with Docker container

[flier]

Support to build with Docker container

[flier]

replace PR #9 Add a Dockerfile for project

[codefromthecrypt]

Maybe add a readme what this is used by or what it is for?

[codefromthecrypt]

did you mean to say envoy here?

[flier]

Oops, just copy the text form Envoy :)

[codefromthecrypt]

does this emit something to console when complete? Does a built binary exist at a known path on the image when complete? Answers to these questions could be in this README

[codefromthecrypt]

thanks, so I can use this image to test code changes and/or build a binary that can be found at the path dist/zipkin-cpp-0.3.1-Linux-x86_64.tar.gz once the build is done. nice!

[flier]

Sure, but it seems you need use git:develop branch instead of outdated 0.3.1

[codefromthecrypt]

I will try this locally

[codefromthecrypt]

wondering if the build also makes the examples? If so, it could be worth mentioning as people could try them (possibly by running the resulting container!)

[codefromthecrypt]

slight glitch running locally as it fails a unit test

$ ./build-dist.sh git:develop
--snip--
QueueImpl.cpp:(.text._ZN7RdKafka9QueueImplD1Ev[_ZN7RdKafka9QueueImplD1Ev]+0x39): undefined reference to `rd_kafka_queue_destroy'
collect2: error: ld returned 1 exit status
make[2]: *** [test/unittest] Error 1
make[1]: *** [test/CMakeFiles/unittest.dir/all] Error 2
make: *** [all] Error 2
test/CMakeFiles/unittest.dir/build.make:190: recipe for target 'test/unittest' failed
CMakeFiles/Makefile2:1091: recipe for target 'test/CMakeFiles/unittest.dir/all' failed
Makefile:140: recipe for target 'all' failed

[flier]

QueueImpl.cpp:(.text._ZN7RdKafka9QueueImplD1Ev[_ZN7RdKafka9QueueImplD1Ev]+0x39): undefined reference to `rd_kafka_queue_destroy'

Seems caused by missing librdkafka C library, it should be fixed in feature/docker-build branch

You may try to use the feature/docker-build branch

$ ./build-dist.sh git:feature/docker-build