fix(stream): log main-frame WebView load errors via onReceivedError#1134
Merged
Conversation
flex3r
requested changes
Jun 11, 2026
flex3r
left a comment
Owner
There was a problem hiding this comment.
Makes sense to add some logging, just two nitpicks
b094a9f to
a0894ef
Compare
Contributor
Author
Done. @flex3r I put the logging you requested. You can check if everything is okay and let me know |
Owner
|
Seems like the linter is not happy with the import order. Running |
Both stream-overlay WebViewClient blocks (StreamWebView and the Compose-side StreamComposeWebViewClient in StreamView) override shouldOverrideUrlLoading but not onReceivedError. When the Twitch embed URL fails to load the overlay stays blank with nothing in the log to debug from. Add a main-frame-only onReceivedError override on both clients that warns through the existing KotlinLogging.logger(...) used elsewhere in the codebase. The isForMainFrame gate keeps blocked sub-resources from spamming the log on every embed.
ee96d57 to
cf20502
Compare
Contributor
Author
@flex3r i fixed the import order and also rebased so there are no conflicts with your develop branch |
flex3r
approved these changes
Jul 10, 2026
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1133.
The two stream-overlay
WebViewClients inui/main/stream/(StreamWebView.ktandStreamView.kt) overrideshouldOverrideUrlLoading(plusonPageFinishedon the Compose one) but neither overridesonReceivedError. When the embed fails to load (network drop, DNS, the player URL moves), the WebView just stays blank with nothing in the log to point at.Add a main-frame-only
onReceivedErroroverride on both clients that logs the failing URL and description through the existingKotlinLogging.logger(...)used elsewhere in the codebase:isForMainFramegate keeps blocked sub-resources from spamming the log on every embed. No UX change: the overlay still does the same thing on success, but stream playback failures now leave a trace.