Skip to content

Fix selectors overlapping bottom toolbars - #590

Closed
amantoux wants to merge 2 commits into
masterfrom
codex/selector-toolbar-position
Closed

amantoux wants to merge 2 commits into
masterfrom
codex/selector-toolbar-position

Conversation

@amantoux

@amantoux amantoux commented Sep 10, 2026

Copy link
Copy Markdown
Member

Color and heading selectors can cover the formatting toolbar when it sits above the keyboard. Position selectors below the presenter when there is room, and flip above it when that side offers more space. Use the full toolbar's vertical bounds while keeping horizontal alignment with the button, and preserve keyboard and safe-area constraints.

@amantoux
amantoux requested a review from Amir-P September 10, 2026 13:13
@amantoux
amantoux marked this pull request as draft September 10, 2026 13:24
@amantoux
amantoux force-pushed the codex/selector-toolbar-position branch from c4b3d6a to 836e461 Compare September 10, 2026 13:25
@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.08405% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.11%. Comparing base (0dbf67a) to head (836e461).

Files with missing lines Patch % Lines
packages/parchment/lib/src/document/embeds.dart 50.00% 4 Missing ⚠️
packages/parchment/lib/src/codecs/html_utils.dart 25.00% 3 Missing ⚠️
...ackages/parchment/lib/src/document/attributes.dart 66.66% 3 Missing ⚠️
packages/parchment/lib/src/codecs/markdown.dart 95.55% 2 Missing ⚠️
packages/parchment/lib/src/document/leaf.dart 66.66% 2 Missing ⚠️
...kages/fleather/lib/src/widgets/editor_toolbar.dart 96.66% 1 Missing ⚠️
packages/parchment/lib/src/document.dart 90.90% 1 Missing ⚠️
packages/parchment/lib/src/document/line.dart 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
+ Coverage   88.08%   88.11%   +0.02%     
==========================================
  Files          63       63              
  Lines       10903    10985      +82     
==========================================
+ Hits         9604     9679      +75     
- Misses       1299     1306       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amantoux
amantoux marked this pull request as ready for review September 10, 2026 15:00
@amantoux amantoux closed this Sep 11, 2026
@amantoux
amantoux deleted the codex/selector-toolbar-position branch September 11, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant