LastComments Feed Slug-Patch#851
Merged
Fraenkiman merged 1 commit intoflatpressblog:masterfrom Mar 28, 2026
Merged
Conversation
- In the comment feed templates, the link {$comment.entry|cmnt:comments_link} has been recalculated. With PrettyURLs, slug generation depends on contextual data; as a result, an outdated or incorrect slug could have been used during rendering.
- The feed templates now use the comment link that has already been correctly prepared, rather than recalculating it at render time, which is prone to errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{$comment.entry|cmnt:comments_link}has been recalculated. With PrettyURLs, slug generation depends on contextual data; as a result, an outdated or incorrect slug could have been used during rendering.