ignition: Improve OEM detection and fix VirtualBox#124
Open
chewi wants to merge 4 commits intoflatcar-masterfrom
Open
ignition: Improve OEM detection and fix VirtualBox#124chewi wants to merge 4 commits intoflatcar-masterfrom
chewi wants to merge 4 commits intoflatcar-masterfrom
Conversation
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
This saves us from having to patch these cases into Ignition like we have previously being doing. It also means we can make a more useful guess than just "metal", which does nothing. For example, this allows you to pass config via qemu_fw when testing PXE with QEMU. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignition: Improve OEM detection and fix VirtualBox
This falls back to detection for cases unsupported by Ignition, which saves us from having to patch these cases into Ignition like we have previously been doing.
It also means we can make a more useful guess than just "metal", which does nothing. For example, this allows you to pass config via qemu_fw when testing PXE with QEMU.
The vboxguest kernel module is added to support VirtualBox against new Ignition versions.
This also drops Equinix Metal (Packet) support.
How to use
The easiest image to test this with is Vagrant... which isn't that easy. You'll need my wider OEM changes.
Testing done
I've tried the above manually run Jenkins, which passed where expected (eventually).