Skip to content

Fix error handling in getMobileDevices to reject promises on failure #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
polyarik wants to merge 1 commit into
base: wcs_api-2.0
Choose a base branch
from
Open

Fix error handling in getMobileDevices to reject promises on failure #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/webrtc-media-provider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1717,12 +1717,13 @@ const getMobileDevices = async function (kind, deviceConstraints = null) {
if (stream.getVideoTracks().length > 0) {
deviceId = stream.getVideoTracks()[0].getSettings().deviceId;
}
stream.getTracks().forEach((track) => {
stream.getTracks().forEach((track) => {
track.stop();
});
}
} catch (error) {
logger.error(LOG_PREFIX, "Can't get device access with video constraints " + JSON.stringify(constraints.video) + ", error " + error);
throw error;
}
return deviceId;
}
Expand Down Expand Up @@ -1752,6 +1753,11 @@ const getMobileDevices = async function (kind, deviceConstraints = null) {
}
} catch (error) {
logger.error(LOG_PREFIX, "Can't get device access with constraints " + JSON.stringify(constraints) + ", error " + error);
throw error;
}

if (!list) {
throw new Error("No media devices found");
}

return list;
Expand Down Expand Up @@ -1894,4 +1900,4 @@ module.exports = {
getAudioSourceDevice: getAudioSourceDevice,
getCacheInstance: getCacheInstance,
getVideoElement: getVideoElement
};
};