build-eth-block: mainnet building#54
Open
zeroXbrock wants to merge 26 commits into
Open
Conversation
ferranbt
approved these changes
Apr 10, 2024
ferranbt
reviewed
Apr 11, 2024
| // } | ||
|
|
||
| // GetBlockHeader gets the beacon block header for a given beacon block ID, or the latest block if blockID is nil. | ||
| func (b *BeaconChain) GetBlockHeader(blockID *common.Hash) (*types.Header, *common.Hash, error) { |
Contributor
There was a problem hiding this comment.
I would assume there is a library already to do this.
ferranbt
reviewed
Apr 11, 2024
| // get latest block from live chain | ||
| // execBlock, err := fr.L1.RPC().BlockByNumber(context.Background(), nil) | ||
| maybe(err) | ||
| beaconBlock, beaconRoot, err := fr.L1Beacon.GetBlockHeader(nil) |
Contributor
There was a problem hiding this comment.
I try to keep the examples valid for both local deployment (local suave-geth) too. Check an example here. Could we have a flag that skips this part of the process if running in local? (Since I am assuming it would be too much to mock everything locally even with Kurtosis).
Member
Author
|
oops, this PR was supposed to just be this commit, branch name confused me. |
zeroXbrock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.