Skip to content

chore: remove the legacy soundcloud set import path - #206

Merged
flamboh merged 1 commit into
feat/share-incomplete-importsfrom
chore/remove-legacy-soundcloud-set-import
Sep 25, 2026
Merged

flamboh merged 1 commit into
feat/share-incomplete-importsfrom
chore/remove-legacy-soundcloud-set-import

Conversation

@flamboh

@flamboh flamboh commented Sep 24, 2026 •

Copy link
Copy Markdown
Owner

Note

🤖 Claude Opus 5.5 on behalf of Oliver

Stacked on #204.

ELI5

Deletes an old copy of the soundcloud import code that the app no longer runs. Only its own tests still used it.

Why

src/features/import/soundcloudSetImport.ts was superseded by the playlist import in audioUrlImportSession.ts. Nothing in src imported it, but it kept a parallel set of helpers alive, and it had already drifted: it never clears the coverPending flag added in #204 when a cover fails to load.

Implementation

  • Deleted soundcloudSetImport.ts.
  • Removed the helpers only it used:
    • startDownloadTrackPlan and its workflow-deps types
    • the SoundCloudSet* plan and input aliases, and createSoundCloudSetDownloadPlan
    • applySoundCloudSetImportedCover
  • soundcloudSet.test.ts keeps its resolveSoundCloudSet test. The three legacy import tests checked real cover rules, so they're rewritten as direct tests of the live applyPlaylistImportedCover:
    • the album cover is set and coverPending ends
    • the cover is copied to tracks only for albums
    • nothing is copied when the "apply cover to tracks" setting or the artwork link is off

Review guide

  • There are no behavior or UI changes. The live playlist and soundcloud import path is untouched.
  • Worth a look: the new applyPlaylistImportedCover tests in fileMetadataOps.test.ts should cover what the deleted harness tests asserted about covers.
  • Verified: vp check passes and all 678 unit tests pass (3 legacy tests removed, 3 direct tests added). A grep for the removed symbols across src, tests, and the docs finds nothing.
  • No manual testing needed beyond a normal soundcloud set import.

Made by Claude Opus 5.5 in Claude Code (T3 Code).

@flamboh
flamboh added this pull request to stack #205 September 24, 2026 23:20
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tagium df352a2 Commit Preview URL

Branch Preview URL
Sep 25 2026, 09:17 AM

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit df352a2.

@flamboh
flamboh marked this pull request as ready for review September 25, 2026 02:44
@flamboh
flamboh force-pushed the chore/remove-legacy-soundcloud-set-import branch from 8a8f534 to 348f066 Compare September 25, 2026 02:55
@flamboh
flamboh force-pushed the chore/remove-legacy-soundcloud-set-import branch from 348f066 to df352a2 Compare September 25, 2026 09:16
@flamboh
flamboh merged commit 7f4443e into main Sep 25, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant