Conversation
flamboh
added this pull request to stack #205
September 24, 2026 23:20
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tagium | df352a2 | Commit Preview URL Branch Preview URL |
Sep 25 2026, 09:17 AM |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
flamboh
marked this pull request as ready for review
September 25, 2026 02:44
flamboh
force-pushed
the
chore/remove-legacy-soundcloud-set-import
branch
from
September 25, 2026 02:55
8a8f534 to
348f066
Compare
flamboh
force-pushed
the
chore/remove-legacy-soundcloud-set-import
branch
from
September 25, 2026 09:16
348f066 to
df352a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 Claude Opus 5.5 on behalf of Oliver
Stacked on #204.
ELI5
Deletes an old copy of the soundcloud import code that the app no longer runs. Only its own tests still used it.
Why
src/features/import/soundcloudSetImport.tswas superseded by the playlist import inaudioUrlImportSession.ts. Nothing insrcimported it, but it kept a parallel set of helpers alive, and it had already drifted: it never clears thecoverPendingflag added in #204 when a cover fails to load.Implementation
soundcloudSetImport.ts.startDownloadTrackPlanand its workflow-deps typesSoundCloudSet*plan and input aliases, andcreateSoundCloudSetDownloadPlanapplySoundCloudSetImportedCoversoundcloudSet.test.tskeeps itsresolveSoundCloudSettest. The three legacy import tests checked real cover rules, so they're rewritten as direct tests of the liveapplyPlaylistImportedCover:coverPendingendsReview guide
applyPlaylistImportedCovertests infileMetadataOps.test.tsshould cover what the deleted harness tests asserted about covers.vp checkpasses and all 678 unit tests pass (3 legacy tests removed, 3 direct tests added). A grep for the removed symbols acrosssrc,tests, and the docs finds nothing.Made by Claude Opus 5.5 in Claude Code (T3 Code).