Repository navigation
feat: spotlight share links for albums and tracks - #203
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tagium | 96b438f | Commit Preview URL Branch Preview URL |
Sep 25 2026, 09:17 AM |
|
React Doctor found 3 new issues in 3 files · 3 warnings · score 93 / 100 (Great) · 3 fixed · vs 3 warnings
Reviewed by React Doctor for commit |
flamboh
added this pull request to stack #205
September 24, 2026 03:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 Claude Opus 5.5 on behalf of Oliver
ELI5
When you import something that can be shared, tagium now points at its menu with a small note that says share links exist. When you open the menu, the share option is highlighted. This works for albums and tracks, and the same mechanism can point out other features later.
Why
Share links are hard to find. The only way in is a
…menu, and on tracks that button stays invisible until you hover over the row.Implementation
SpotlightUI primitive (src/components/ui/spotlight.tsx): a shadcn-style set of components built on the Radix popover. The anchor gets a pulsing brand-colored outline, andspotlightItemClassNamehighlights a matching menu item.src/features/discovery/featureDiscovery.ts): one "seen" flag per feature, stored together inlocalStorageundertagium:feature-discovery(for example{"share-links":true}). To add another feature, extend theDiscoverableFeatureunion and calluseFeatureDiscovery("<feature>").SpotlitActionMenu: the…menu for both album cards and track rows. Pass it anActionSpotlight(actionId, title, description,onDismiss) and it shows the note, handles "got it" / "show me", and highlights that action in the menu.useShareLinkSpotlight: picks where to point. It prefers the first album that can create a share link, and otherwise the first track that can. Albums and tracks share the singleshare-linksflag.Review guide
Setup: run with
VITE_PUBLIC_SHARE_LINKS_ENABLED=true, and removetagium:feature-discoveryfrom localStorage to see the note again.Flows to check
…button ("anyone with the link gets this album with your tags and artwork.").…button.…button). The note goes away, the menu opens, and the share item is tinted. Picking it opens the normal share dialog.Edge cases
prefers-reduced-motionturns off the pulse.Decisions for the reviewer
…menu with Escape also clears the editor selection. That already happens onmainand isn't changed here.Verified
vp checkpasses, and all 671 unit tests pass, including new tests for the discovery flags (merging, bad storage, persistence) and share targeting (album first, track fallback, visibility, one shared flag, copy for each kind).UI Changes
Before: sharing only lives in the

…menus, and nothing points to it.After (album): the note next to the album menu, then the highlighted share item and the share dialog.




After (track):


Album flow:
https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/081bc13409215f9a/album-flow.webm
Made by Claude Opus 5.5 in Claude Code (T3 Code).