Repository navigation
history: what the person did is whatever the host says the person did - #60
Merged
Merged
Conversation
An edit after going back used to drop everything gone back over. Now the steps gone back over return to the line, then their reverses, then the edit: the sprite is where it was gone back to, and every step is still on the line. The reverses read "Back to <step>" and are credited to whoever went back. Kinds that don't swap the same way both directions (resize, deleted layers and animations, merges, cell reorders, grid changes) still drop what was gone back over, as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pixi counted an edit or an undo as the person's when none of pixi's own commands was running, so an agent's `fizzy.undo` (fizzy's command, not pixi's) came back to it as "the person changed this sprite". It now asks the host who is acting (`Host.author`). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
main holds #59 squashed; this branch keeps its own reading of who acts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #59; merge after it, which retargets this to
main. Part of fizzyedit/plans#14.What changes
Pixi tells an agent what the person did to a sprite since its last command (
History.person, pixi#46). It counted an edit, undo or redo as the person's when none of pixi's own commands was running (commands.running == 0).That stopped being true when fizzy's
fizzy.undo .{ .path }(fizzyedit/fizzy#487) began reaching pixi throughhistoryGoTo: that is fizzy's command, not pixi's. So an agent undoing its own draw was told, with its next command's answer, "the person changed this sprite since your last command on it".Both places now ask the host who is acting (
Host.author().kind == .person): the person at the keys, an agent's call, a tape.commands.runningstays for what it is still for: telling the person's activity with the running command's answer.Verified
Live on macOS (the sandbox from #59): an MCP client drew, undid with
fizzy.undo .{ .path }, drew, and undid four times more..person = .{ .note = "the person changed this sprite…", .undone = 1 }, four in all.The person's own undo by key was not driven live, since a tape's key is its tape's author, not the person's. It is the host's input author that marks it as the person's.
zig build(sandbox,--fork),zig fmt --check.🤖 Generated with Claude Code