Skip to content

layout: test the picker's empty header - #473

Merged
foxnne merged 1 commit into
mainfrom
layout/picker-empty-test
Oct 16, 2026
Merged

foxnne merged 1 commit into
mainfrom
layout/picker-empty-test

Conversation

@foxnne

@foxnne foxnne commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Follow-up to #470, from its review.

What changes

  • The place being edited, when empty, draws its header and "Nothing here yet." inside a box anchored picker.empty, so a test or a demo tape can find it.
  • The picker integration test checks it: once Files and Output both sit in the Panel, the Sidebar's picker leads with picker.empty above the Panel's cards, and the Panel's picker has none.
  • A comment said the sections were "sorted"; they are computed once.

SDK impact

  • None

Verified

  • macOS: the picker integration test passes, and fails without the anchor; all gates pass locally (fmt, build, test, test-integration 53/53 steps, check-web, test-sdk-version).
  • Windows:
  • Linux:
  • Web:

Follow-ups

None planned.

🤖 Generated with Claude Code

From #470's review. The empty place's header ("Nothing here yet.") now
carries a `picker.empty` anchor, and the picker integration test checks it
leads the Sidebar's picker once the Sidebar holds nothing, and is absent from
the Panel's. Also corrects a comment that said the sections are sorted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@foxnne
foxnne enabled auto-merge (squash) October 16, 2026 21:41
@foxnne
foxnne merged commit 88233a9 into main Oct 16, 2026
11 checks passed
@foxnne
foxnne deleted the layout/picker-empty-test branch October 16, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant