Repository navigation
core: viz tables have a rounded header and shaded rows, no border - #359
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
foxnne
marked this pull request as ready for review
October 10, 2026 22:21
foxnne
added a commit
that referenced
this pull request
Oct 11, 2026
## What changes `sdk_version` goes from 0.2.22 to 0.2.23. Merging tags `sdk-v0.2.23`, publishes its tarball, and asks the store plugins to repin. **Why now.** The plugin boundary's fingerprint moved since `sdk-v0.2.22` (`0x1bf417f6…` → `0x65096e94…`, by #360), so store plugins built against 0.2.22 don't load in a fizzy built from `main`, and fizzyed.it/app is built from `main`. Also, #355 moved the `plugins` service to version 2, and the agent plugin's `fizzy_build` asks for version 1 until it repins. ## SDK impact - [ ] None - [ ] Core-only or additive: reaches plugins at the next SDK release - [ ] Fingerprint moved: recorded in `sdk/src/version.zig`, `sdk_version` untouched, PR labelled `sdk` - [x] SDK release: bumps `sdk_version`, lists the `sdk` PRs since the last `sdk-v*` tag **The `sdk` PRs since `sdk-v0.2.22`:** - #360: a plugin's panic message reaches its crash report. This moves the fingerprint. **Additive, reaching plugins with this release:** - #355: the `plugins` service is version 2, with `list` (each plugin's identity, link, version, registration counts and status). A caller built for version 1 is refused until it rebuilds, which this release's repin does. - #351: a crash report says whose code crashed (`sdk/plugin_sdk.zig`). **Also reaching plugins (`core/`):** - `core.viz`, graphics for live numbers: `line`, `bar`, `stat`, `Table` (#345); `Pie`, `keyColor`, `palette` (#347); the table's rounded header and shaded rows (#359). - `core.profile`: - `lookback()`: 30 s of costs and the frames over budget, plus `ReportOptions.over_ms` / `.hitches` and `selfTimes` (#353). - `frameCauses()` and `ReportOptions.causes`: why each frame happened (#364). - `phase` / `Phases` / `ReportOptions.startup`: startup timing (#365, which landed inside #364's squash commit). - The profiler's `abi` stays 4. ## Verified - [x] macOS: - `zig build` and `test-sdk-version` on this head. - `scripts/pack-sdk.sh` packs `fizzy-sdk-v0.2.23.tar.gz`. - Every store plugin (fresh pulls of pixi, zig, drive, atlas and ghostty `main`) builds against this tree's `sdk/` with `zig build --fork=<sdk>` into a throwaway profile (31/31, and 28/28 for each of the other four). The fingerprint moved, so each repin PR is a real rebuild, but none should open as a draft for a broken build. The agent and chat plugins build too (22/22, 19/19). - [ ] Windows: - [ ] Linux: CI. - [ ] Web: ## Follow-ups - Each repin PR merged and its plugin tagged (the plugin repos' tags stay the maintainer's). - `fizzyedit/agent` and `fizzyedit/chat` repin to the `sdk-v0.2.23` tarball. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The profiler's table had a border whose top edge was square and bottom rounded. @foxnne suggested alternating shaded rows, no border, and a rounded header.
Why the top was square: dvui's grid defaults to a 1 px border with square top corners, expecting a header joined to its top edge.
viz.Tableturned the grid's background off but kept that border.Now (
core/viz/Table.zig):A strip is its cells side by side: each cell is filled, the first column's left corners and the last column's right corners rounded (
stripe). The shade is the theme's text colour at 8% for the header and 4% for rows, so it reads in light and dark themes alike. The profiler is the onlyviz.Tabletoday.Verification:
zig build,test(531/532),test-integration(363/363),check-webandtest-sdk-versionpass on macOS.🤖 Generated with Claude Code