Repository navigation
Fix remaining clippy 1.97 lints (lash-cli, lash-tui) - #22
Merged
Merged
Conversation
CI's stable clippy (1.97) flags useless_borrows_in_formatting and assert!-with-equality across tests and a TUI format! call that older clippy did not. Drop the redundant & in two format args and switch three assert!(a == b)/(a != b) test lines to assert_eq!/assert_ne!. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fohara
added a commit
that referenced
this pull request
Aug 6, 2026
CI's stable clippy (1.97) flags useless_borrows_in_formatting and assert!-with-equality across tests and a TUI format! call that older clippy did not. Drop the redundant & in two format args and switch three assert!(a == b)/(a != b) test lines to assert_eq!/assert_ne!.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #21. CI's stable clippy is now 1.97, which stops at the first crate with a lint, so #21 only cleared
lash-types; the run then failed inlash-tui/lash-cli. Ran clippy 1.97 locally with--keep-goingto surface everything at once:useless_borrows_in_formatting— dropped the redundant&informat!("#{}", label.name)(filter_modal) and aneprintln!arg (lash-tui integration test).assert!with an equality comparison — switched three test asserts toassert_eq!/assert_ne!(check_links core, file_discovery).Verified:
cargo +stable clippy --workspace --all-targets -- -D warnings(rustc 1.97.0) is clean,cargo fmt --all --checkclean.🤖 Generated with Claude Code