Repository navigation
Fix @depends-on / @id resolution across lint, check-links, and CLI (#14–#19) - #20
Merged
Merged
Conversation
Add a shared reference resolver (dependency::reference) that understands bare @id, #task:id, file-id#task:id, path#task:id, and file-level forms, and route the linter's DependencyExistsRule through it so all documented and natural reference forms resolve. Split comma-separated @depends-on lists into multiple refs, and report E_LINK_NOT_FOUND at the offending @depends-on: line instead of :0:0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Explicit @depends-on edges are not stored as NULL-target rows, so the DB query behind check-links never saw them and reported clean while lint flagged the same references. Reparse the tree and resolve each reference through the shared resolver, merging broken ones into the report. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
show/start/complete now accept a task's @id (its local_id), not just the file-id#slug full id, via a shared task_target resolver backed by a new TaskRepository::get_by_local_id. Ambiguous @ids list candidate full ids. show now reports a missing task as a not-found diagnostic (exit 5) instead of the miscategorized E_INTERNAL. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lash complete now refuses when a task has a resolvable @depends-on target that isn't done or waived, listing the unmet dependencies (E_DEP_UNMET). Pass --force to override. Dependencies are resolved from the current Markdown via the shared resolver, since explicit edges aren't indexed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Update references/dependencies.md to document the natural @depends-on forms (bare @id, file-id#task:id, comma lists) and the completion gate. Record the work in devlog.md and the tasks index. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fohara
added a commit
that referenced
this pull request
Aug 6, 2026
#19) (#20) * Fix @depends-on reference resolution in linter (#15, #16, #18) Add a shared reference resolver (dependency::reference) that understands bare @id, #task:id, file-id#task:id, path#task:id, and file-level forms, and route the linter's DependencyExistsRule through it so all documented and natural reference forms resolve. Split comma-separated @depends-on lists into multiple refs, and report E_LINK_NOT_FOUND at the offending @depends-on: line instead of :0:0. * Make check-links validate @depends-on like lint (#19) Explicit @depends-on edges are not stored as NULL-target rows, so the DB query behind check-links never saw them and reported clean while lint flagged the same references. Reparse the tree and resolve each reference through the shared resolver, merging broken ones into the report. * Resolve bare @id as a command target (#14) show/start/complete now accept a task's @id (its local_id), not just the file-id#slug full id, via a shared task_target resolver backed by a new TaskRepository::get_by_local_id. Ambiguous @ids list candidate full ids. show now reports a missing task as a not-found diagnostic (exit 5) instead of the miscategorized E_INTERNAL. * Enforce @depends-on on complete with --force override (#17) lash complete now refuses when a task has a resolvable @depends-on target that isn't done or waived, listing the unmet dependencies (E_DEP_UNMET). Pass --force to override. Dependencies are resolved from the current Markdown via the shared resolver, since explicit edges aren't indexed. * Document dependency-resolution fixes and update skill docs Update references/dependencies.md to document the natural @depends-on forms (bare @id, file-id#task:id, comma lists) and the completion gate. Record the work in devlog.md and the tasks index. ---------
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a cluster of
@depends-on/@idresolution bugs (GitHub issues #14–#19).Root cause
Three divergent resolution paths — the linter rule, an unused graph resolver, and DB full-id lookup — plus a resolver that only understood the undocumented
file-id#fragment-slugform. Explicit@depends-onedges were also never inserted into the index, socheck-links(which queries the DB) never saw them.The central fix is a single shared resolver (
lash-core::dependency::reference::resolve_reference) thatlint,check-links, andcompleteall route through, so the surfaces agree.Fixes
@depends-onresolves only the undocumentedfile-id#fragment-slugform; bare@idand both documented#task:forms fail E_LINK_NOT_FOUND #15 — resolver understands bare@id,#task:id/#id,file-id#task:id/file-id#id,path.md#task:id, and file-level forms (thetask:prefix is optional everywhere).@depends-onlist is parsed as a single reference #16 —@depends-on: a, bsplits into multiple references at parse time.@depends-online #18 —E_LINK_NOT_FOUNDreports the offending@depends-on:line instead of:0:0.check-linksreports "No broken links found!" whilelintflags E_LINK_NOT_FOUND@depends-onrefs in the same project #19 —check-linksreparses and validates@depends-onwith the same resolver aslint.show/start/completeaccept a task's bare@id(newTaskRepository::get_by_local_id);showreports a missing task as a not-found diagnostic (exit 5) instead of the miscategorizedE_INTERNAL.@depends-onis never enforced:completesucceeds andlintstays silent while a valid dependency is still open #17 —lash completerefuses while a resolvable dependency is still open (E_DEP_UNMET), with--forceto override.Testing
Unit tests added for every reference form, comma splitting, line-number reporting, check-links agreement,
@idcommand resolution (unique/ambiguous/missing), and the completion gate. Verified all six issue repros end-to-end via the CLI. Full workspace test suite passes (0 failures).Closes #14
Closes #15
Closes #16
Closes #17
Closes #18
Closes #19
🤖 Generated with Claude Code