Skip to content

ci: provide API_BASE_URL so env generation no longer fails - #23

Merged
laithanhhung merged 1 commit into
devfrom
fix/ci-api-base-url
Jul 24, 2026
Merged

ci: provide API_BASE_URL so env generation no longer fails#23
laithanhhung merged 1 commit into
devfrom
fix/ci-api-base-url

Conversation

@laithanhhung

@laithanhhung laithanhhung commented Jul 24, 2026

Copy link
Copy Markdown
Member

The Lint/Test/Build job ran generate-env.mjs (via pretest:ci and prebuild), which hard-fails when API_BASE_URL is unset. Inject it at the job level (secret/var override, committed public fallback) and pass the same build-args to the deploy image build.

Summary by CodeRabbit

  • Chores
    • Improved application build and deployment configuration by ensuring required service settings are available during continuous integration and Docker builds.
    • Added fallback handling for the application service URL when no configured value is provided.

The Lint/Test/Build job ran generate-env.mjs (via pretest:ci and
prebuild), which hard-fails when API_BASE_URL is unset. Inject it at the
job level (secret/var override, committed public fallback) and pass the
same build-args to the deploy image build.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@kody-ai

kody-ai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Code Review Could Not Complete ⚠️

The review failed before suggestions could be generated.

Reason: The configured API key (google_gemini) is out of credits or has hit its billing limit. Top up the account or adjust the plan.

After fixing the issue, comment @kody review on this PR to re-run the review.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug
Performance
Security
Business Logic

Access your configuration settings here.

@laithanhhung
laithanhhung merged commit e5195f0 into dev Jul 24, 2026
1 of 3 checks passed
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9db4ee83-71c4-4645-818f-5855793799a6

📥 Commits

Reviewing files that changed from the base of the PR and between c4653d8 and d7aad30.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

The CI workflow adds API and Goong configuration variables to the CI environment and passes them as build arguments when creating the deployment Docker image.

Changes

CI environment propagation

Layer / File(s) Summary
Workflow environment and Docker build arguments
.github/workflows/ci.yml
The CI job defines API_BASE_URL with a fallback and adds Goong API keys; the deploy job forwards all three values to the Docker build.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: giabaongo

Poem

I’m a bunny in the CI flow,
Carrying keys where builds must go.
APIs hop through Docker’s door,
Fallbacks wait upon the floor.
Fresh images bloom—hop, hop, hooray!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-api-base-url

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant