Feature/remove status field#30
Merged
Merged
Conversation
Comment on lines
+13
to
+14
| ## Breaking Changes | ||
| - The `status` field has been removed from `reddit_ads__account_report`. Since `status` was previously part of the aggregation grain (included in the `GROUP BY`), this change will alter the granularity of the reporting table. Users who previously relied on account-level reporting by status will need to adjust their downstream queries and models accordingly. |
Contributor
There was a problem hiding this comment.
I would consolidate this to the comments for reddit_ads__account_report since it's the same info.
| ## Breaking Changes | ||
| - The `status` field has been removed from `reddit_ads__account_report`. Since `status` was previously part of the aggregation grain (included in the `GROUP BY`), this change will alter the granularity of the reporting table. Users who previously relied on account-level reporting by status will need to adjust their downstream queries and models accordingly. | ||
|
|
||
| ## Documentation |
Contributor
There was a problem hiding this comment.
Minor thing--update these to the present tense.
Contributor
Author
There was a problem hiding this comment.
I folded the part you made this comment about into the above definition per another comment. Tenses are kind of mixed throughout changelogs, so let me know if it's still not quite right.
Contributor
Author
|
@fivetran-catfritz This should be good to go but let me know if it needs anything else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
Submission Checklist
Changelog