Fix steady memory growth (~200 MB/granule) with geometry="swath"#69
Merged
Fix steady memory growth (~200 MB/granule) with geometry="swath"#69
Conversation
…, gc.collect Co-authored-by: eeholmes <2545978+eeholmes@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Diagnose and resolve memory accumulation with level 2 swath
Fix steady memory growth with geometry="swath" (L2/swath data)
Mar 9, 2026
Copilot
AI
changed the title
Fix steady memory growth with geometry="swath" (L2/swath data)
Fix steady memory growth (~200 MB/granule) with geometry="swath"
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
geometry="swath"usesxr.open_datatree()+xr.merge()to open each granule. Unlikexr.open_dataset(), the DataTree was never explicitly closed, so HDF5 file handles and their backing memory accumulated across granules until Python's cyclic GC eventually ran.Changes
Primary fix —
_open_as_flat_dataset→@contextmanager: DataTree is now explicitly closed in afinallyblock after each granule is processed, matching the cleanup behaviour ofxr.open_dataset():gc.collect()after each batch: DataTree nodes contain parent→child reference cycles, so CPython's reference-counting GC doesn't free them promptly. An explicitgc.collect()afterdel opened_batchensures they're reclaimed before the next batch opens.Batch xoak index build (
_extract_xoak_batch): The old code rebuilt theNDPointIndexk-d tree once per query point per granule. The new_extract_xoak_batchbuilds it once per granule and queries all points in a singlesel()call, reducing both memory churn and CPU cost.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.