Repository navigation
Screenshots: push with a deploy key past a ruleset - #43
Merged
Merged
Conversation
Like bump-version.yml (#42): the optional secret deploy-key checks out and pushes with a deploy key on the ruleset's bypass list. The Playwright image brings openssh-client (utils/docker/Dockerfile.noble in microsoft/playwright). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y3rdfXpBafq4kFbwiY2UFF
firsttris
added a commit
to firsttris/haben
that referenced
this pull request
Nov 8, 2026
## Anlass Wie beim Bump (#397, #398): Das Ruleset auf `main` lehnt Pushes mit dem `GITHUB_TOKEN` ab, deshalb kann *Update screenshots* auf `main` seinen Commit nicht mehr pushen. ## Änderung - `.github/workflows/screenshots.yml`: gepinnt auf `e3bd464`, den Merge-Commit von firsttris/workflows#43 auf `main`. Übergibt `BUMP_DEPLOY_KEY` als `deploy-key`. Das ist derselbe Deploy Key wie beim Bump, er steht schon auf der Bypass-Liste. Den Kommentar am Pin habe ich von `# v1` auf `# main` geändert, weil der Commit nicht auf dem Tag `v1` liegt. - `docs/entwicklung.md`: ein Satz zum Push auf `main` mit dem Deploy Key. Im Playwright-Image ist `openssh-client` installiert, deshalb funktioniert der Deploy Key auch im Container. Getestet ist das erst mit dem ersten Lauf auf `main` nach dem Merge. Der Commit mit den Bildern startet dann die CI auf `main`. --- _Generated by [Claude Code](https://claude.ai/code/session_01Y3rdfXpBafq4kFbwiY2UFF)_ Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Same problem as #42: in firsttris/haben the ruleset on
main(pull request, status checks) refuses theGITHUB_TOKEN, so Update screenshots onmaincan no longer push its commit.What
screenshots.yml: optional secretdeploy-key, passed toactions/checkoutasssh-key.commit-changesthen pushes over SSH with that key. Without the secret nothing changes.mcr.microsoft.com/playwright:vX-noble) installsgit openssh-client(Dockerfile.noble), so SSH works in the job's container.Checks
YAML parses; actionlint runs in Lint. Not run end to end yet: that happens with the first run in haben after this is merged.
Generated by Claude Code