Repository navigation
Run Playwright's test runner on Bun - #81
Conversation
The end-to-end tests and the screenshots now start the runner with `bun --bun playwright test`, as firsttris/haben does and as the tech stack asks; Node is no longer needed to develop or test SnapRAID UI. CI installs the browser with `bun --bun playwright install`, test:image runs the runner the same way, and the docs, the README and Renovate's Bun note drop Node. Checked with Node removed from PATH: the local and the binary targets pass the same tests as with the runner on Node. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y3rdfbWb1xDUdPRng7TX9Z
TDD review: no proven findingsReviewed the diff ( Checked and not proven:
Known issues (changes.spec "deleted and encrypted files…" on the binary target, the flaky scheduled-sync test) were not counted, as agreed. Note: Generated by Claude Code |
|
TDD-Review abgeschlossen: keine belegten Findings (Details im vorigen Kommentar). CI grün: backend, frontend, install, e2e local 1–2/2, e2e binary 1–2/2, e2e image 1–2/2 – damit läuft der Playwright-Runner auch im CI-Runner und im Image auf Bun. Merge per Squash. Generated by Claude Code |
Runs Playwright's test runner on Bun (
bun --bun playwright test) instead of Node, as firsttris/haben does and as the tech stack asks. With this, nothing in the repository needs Node any more.e2e/package.json:testandscreenshotsrunbun --bun playwright teste2e/scripts/image-test.sh:bun --bun playwright testinstead ofbunx playwright testci.yml(e2e jobs for local, image and binary):bun --bun playwright install --with-deps chromium; the comment no longer says the runner runs on Nodescreenshots.ymlneeded no change: it runsbun run screenshots, and Bun still comes fromnpm install --global "bun@…"in the Playwright imagedocs/development.md,README.md, Renovate's Bun note: Node is no longer listed as a requirement for the end-to-end testsTests
Run locally with Node removed from
PATH, compared with the runner on Node (same checkout, same Chromium):schedules.spec.ts"a disk that is not mounted…", passed twice on a rerun under Node: flaky)Skipped:
docker.spec.ts(no Docker daemon) and, on the local target,binary.spec.ts. The failure on the binary target is the same under both runners and does not come from this change:changes.spec.ts"deleted and encrypted files are restored…" finds two"Restore" finished successfullytoasts (the first restore's is still visible when the second finishes) and trips strict mode. The screenshot config lists its 14 tests under Bun andbun run typecheckpasses; the screenshots themselves were not taken here.Generated by Claude Code