Repository navigation
Renovate: Bun of packageManager in the Bun group; toolbox installs that Bun - #21
Merged
Merged
Conversation
Renovate's bun manager already reads "packageManager": "bun@x.y.z" of app/package.json as the npm package `bun`. The Bun group matched only oven-sh/bun (the regex managers), so `bun` went into the monthly, self-merging minor-patch group without the Flatpak's Bun binaries, and the regex manager for the same line edited it a second time. Drop that regex manager and add `bun` to the group, as in firsttris/fernsicht#18 and firsttris/stellwerk#26. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y3rdfbWb1xDUdPRng7TX9Z
…here packaging/toolbox.sh skipped the install whenever any Bun was on PATH, so a toolbox kept an older Bun than CI (setup-bun with bun-version-file) and the Renovate Bun PR, and with "packageManager" written without a space it handed the installer an empty tag (`bun-v`), i.e. the newest Bun. Compare the installed version with packageManager, read it with an optional space and stop when none is found. The installer's $1 is the release tag (src/runtime/cli/install.sh in oven-sh/bun). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y3rdfbWb1xDUdPRng7TX9Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate's bun manager already reads
"packageManager": "bun@x.y.z"inapp/package.jsonas the npm packagebun(also in the subfolder: nounknown-enginesskip in the run below). The Bun group matched onlyoven-sh/bun(the regex managers), sobunwent into the monthly, self-mergingrenovate/minor-patchgroup without the Flatpak's Bun binaries, while the regex manager for the same line read it a second time. This drops that regex manager and addsbunto the Bun group; the Flatpak's Bun archives (oven-sh/bun, regex manager on the manifest) stay in it.The
oven-sh/bunlookups (github-releases) could not run here: Renovate wants a GitHub token for them and this session has no GitHub API access to oven-sh/bun (github-token-requiredbelow). Their group rule is unchanged (matchPackageNamesstill namesoven-sh/bun).Test
A Renovate 44.211.0 lookup run (
--platform=local --dry-run=lookup) on a copy of the Bun-related files with Bun pinned back to 1.3.0, checking the branch of every Bun update and thatpackageManageris read by one manager only (the check of firsttris/fernsicht#18 and firsttris/stellwerk#26, extended by the second point).Before (
origin/main):After (this branch):
renovate-config-validator --strict(Renovate 44.211.0):Config validated successfully.Toolbox installs the Bun of
packageManagerpackaging/toolbox.shalready passed the version to the installer, but skipped the install whenever any Bun was onPATH(an older Bun stayed), and with"packageManager":"bun@…"written without a space it built an empty tag (bun-v, i.e. the newest Bun). It now compares the installed version withpackageManager, reads it with an optional space (stillsed, no jq/node) and stops when none is found.$1of the official installer is the release tag (src/runtime/cli/install.shin oven-sh/bun).docs/development.mdhas no Bun install line to change.Test: runs
toolbox.shfrom a copy with stubs fortoolbox,curl,bashandbun(nothing downloaded or installed) and checks the installer command line.Before (
origin/main):After:
Test script
Generated by Claude Code