Repository navigation
Renovate reads the Bun of packageManager once; toolbox installs that Bun - #15
Merged
Merged
Conversation
Renovate's bun manager already reads "packageManager": "bun@x.y.z" of app/package.json as the npm package `bun`, so the regex manager for the same line extracted it a second time and both edited it. Drop the regex manager; the Bun group matches `bun` already. As in firsttris/fernsicht#18 and firsttris/stellwerk#26. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y3rdfbWb1xDUdPRng7TX9Z
packaging/toolbox.sh and the Debian lines of docs/development.md installed the newest Bun, so a fresh toolbox could run another Bun than CI (setup-bun with bun-version-file) and the Renovate Bun PR. Read the version from "packageManager" in app/package.json with sed and hand the official installer its release tag (`bash -s bun-v<version>`, the $1 of src/runtime/cli/install.sh in oven-sh/bun); the toolbox keeps a Bun that already has that version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y3rdfbWb1xDUdPRng7TX9Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate's bun manager already reads
"packageManager": "bun@x.y.z"inapp/package.jsonas the npm packagebun(also in the subfolder: nounknown-enginesskip in the run below). The extra regex manager read the same line a second time, so two dependencies edited it. This drops the regex manager; the Bun group matchesbunalready, so its grouping was right and stays so.Test
A Renovate 44.211.0 lookup run (
--platform=local --dry-run=lookup) on a copy of the Bun-related files with Bun pinned back to 1.3.0, checking the branch of every Bun update and thatpackageManageris read by one manager only (the check of firsttris/fernsicht#18 and firsttris/stellwerk#26, extended by the second point).Before (
origin/main):After (this branch):
renovate-config-validator --strict(Renovate 44.211.0):Config validated successfully.Toolbox and Debian setup install the Bun of
packageManagerpackaging/toolbox.shand the Debian lines ofdocs/development.mdinstalled the newest Bun (curl … | bash), not the one CI runs. They now read the version from"packageManager"inapp/package.jsonwithsed(no jq/node) and pass the release tag to the official installer (bash -s bun-v<version>;$1is the tag insrc/runtime/cli/install.shof oven-sh/bun). The toolbox keeps a Bun that already has that version.Test: runs
toolbox.shand the docs' Debian line from a copy, with stubs fortoolbox,curl,bashandbun(nothing downloaded or installed), and checks the installer command line.Before (
origin/main):After:
Test script
https://claude.ai/code/session_01Y3rdfbWb1xDUdPRng7TX9Z
Generated by Claude Code