Adding neopixel protocol proposal#18
Open
graysonarts wants to merge 4 commits intofirmata:masterfrom
graysonarts:master
Open
Adding neopixel protocol proposal#18graysonarts wants to merge 4 commits intofirmata:masterfrom graysonarts:master
graysonarts wants to merge 4 commits intofirmata:masterfrom
graysonarts:master
Conversation
Member
|
I'd prefer if the protocol could be generalized so it could work with any LED strip rather than specifically for the NeoPixel. So this would be the LED strip protocol. Your NeoPixel implementation for configurable firmata would then be a NeoPixel specific implementation of the LED strip protocol. If the protocol however must be specific to the NeoPixel then I'd prefer this be added as an example rather than part of the official protocol since I'm trying to avoid device-specific implementations. |
…the fact that WS2801s need clock pin also
Author
|
Updated the reflect the rename. I needed to change the configuration slightly since WS2812s and WS2801s have slightly different requirements for configuration, so I've added a "strip specific configuration" section to the initialization wrapper. |
507a726 to
c0449c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to the issue that I created over on firmata/arduino for adding LED strip support to firmata: issues#167