[BHP1-1510] Update VMS with new Direction Variables Attribute#195
Open
Kcheung42 wants to merge 3 commits intokc-BHP1-1355-feat-consolidate-direction-variables-settingsfrom
Open
[BHP1-1510] Update VMS with new Direction Variables Attribute#195Kcheung42 wants to merge 3 commits intokc-BHP1-1355-feat-consolidate-direction-variables-settingsfrom
Kcheung42 wants to merge 3 commits intokc-BHP1-1355-feat-consolidate-direction-variables-settingsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Related Issues
Closes BHP1-1510
Submission Checklist
BHP1-### <title>)clj-kondo --lint components/**/src bases/**/src projects/**/src)clojure -M:compile-cljs)Testing
Open local vms and run migration script
2026-03-03-add-direction-variables-attr-to-group-variablesEnsure for these "Directional Parent" (the ones with no direction set) variables exist and it's corresponding Directional Children exists. All Directional Parents have it's children listed under "Direction Variables" header. All children are properly configured with the cpp code and conditionals that trigger them to be enabled.
Surface > Fire Behavior (output) > Surface Fire : Rate of Spread
Surface > Fire Behavior (output) > Surface Fire : Flame Length
Surface > Fire Behavior (output) > Surface Fire : Fireline Intensity
Surface > Fire Behavior (output) > Surface Fire : Spread Distance
Mortality > Mortality (output) > Tree Mortality : Probability of Mortality
Mortality > Mortality (output) > Tree Mortality : Scorch Height
Mortality > Mortality (output) > Tree Mortality : Tree Crown Length Scorch
Mortality > Mortality (output) > Tree Mortality : Tree Crown volume Scorch
Mortality > Mortality (output) > Tree Mortality : Bole Char Height
Screenshots
Notice some quality of life changes to the views to differentiate between directional children and its parent
