Skip to content

[BHP1-1290] Relative Humidity Tool#119

Merged
rjsheperd merged 3 commits intomainfrom
rj-BHP1-1290-relative-humidity-tool
Aug 27, 2025
Merged

[BHP1-1290] Relative Humidity Tool#119
rjsheperd merged 3 commits intomainfrom
rj-BHP1-1290-relative-humidity-tool

Conversation

@rjsheperd
Copy link
Contributor

Purpose

Creates a new Relative Humidity Tool. Please be sure to review the accompanying C++ changes here: firelab/behave#54

Related Issues

Closes BHP1-1290

Submission Checklist

  • Included Jira issue in the PR title (e.g. BHP1-### <title>)
  • Code passes linter rules (clj-kondo --lint components/**/src bases/**/src projects/**/src)
  • Feature(s) work when compiled (clojure -M:compile-cljs)

Testing

  1. Start VMS, run migration migrations.2025-08-03-add-relative-humidity-tool
  2. Start App, sync
  3. Open "Calculators" -> "Relative Humidity"
  4. Use the following numbers to verify:
image

@Kcheung42
Copy link
Collaborator

2025_08_03_add_relative_humidity_tool.clj

  • ln 29: missing conn as second argument
  • ln 85: missing definition for global-namespace
  • ln 85: missing definition for relative-humidity-class

@Kcheung42
Copy link
Collaborator

Noticing when changing units, the inputs and outputs aren't being recomputed.

@rjsheperd
Copy link
Contributor Author

@Kcheung42 that's only for auto-computing tools. This isn't set up that way. We'll be looking at adding the global Metric/English switch to make this more straightforward.

@Kcheung42
Copy link
Collaborator

Oh that's right, I was looking at 1-hr fuel moisture tool

@Kcheung42
Copy link
Collaborator

looks Good! approved!

@rjsheperd rjsheperd merged commit 817f8ec into main Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants