Repository navigation
Add explicit llama.cpp LLM provider - #759
Abhishekpandey123-git wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
@marcvergees This PR addresses the explicit llama.cpp provider portion of #702. The Ollama-vs-llama.cpp benchmark work will be handled separately so the provider implementation and benchmarking can be reviewed independently. |
|
Thanks @Abhishekpandey123-git. A few notes on nice to haves you could add:
|
374b10f to
479096a
Compare
|
Hi @Abhishekpandey123-git, Imma review this asap, but me and @vharkins1 are working rn on the desktop deployment, which is the most urgent thing rn because we might be onboarding again next week. I haven't forgot your stuff, don't worry! |
Summary
llama_cppas an explicit LLM provider.Implementation
The current LLM architecture already supports OpenAI-compatible endpoints, so no separate llama.cpp service implementation is required.
The provider is registered with:
Validation
git diff --checkpasses.PYTHONPATH=. pytest -q tests/test_llm_service.py tests/test_llm_registry.pyPYTHONPATH=. pytest -q tests/test_llm_service.py tests/test_llm_registry.py tests/test_api.pyThe only reported warnings are existing Pydantic deprecation warnings.
Context
This PR is a fresh replacement for the previous llama.cpp provider PR, which was closed after its target branch was deleted. It is based on the current
developmentbranch as requested.The benchmark work will be handled separately so the explicit provider implementation can be reviewed independently.