Skip to content

Add explicit llama.cpp LLM provider - #759

Open
Abhishekpandey123-git wants to merge 2 commits into
fireform-core:developmentfrom
Abhishekpandey123-git:feat/llama-cpp-provider-v2
Open

Abhishekpandey123-git wants to merge 2 commits into
fireform-core:developmentfrom
Abhishekpandey123-git:feat/llama-cpp-provider-v2

Conversation

@Abhishekpandey123-git

Copy link
Copy Markdown

Summary

  • Add llama_cpp as an explicit LLM provider.
  • Register llama.cpp in the current provider specification system.
  • Use the existing OpenAI-compatible LLM transport with the default llama.cpp server endpoint.
  • Keep the provider API-key-free, matching a local llama.cpp deployment.

Implementation

The current LLM architecture already supports OpenAI-compatible endpoints, so no separate llama.cpp service implementation is required.

The provider is registered with:

llama_cpp
http://127.0.0.1:8080/v1
needs_key=False

Validation

  • git diff --check passes.
  • PYTHONPATH=. pytest -q tests/test_llm_service.py tests/test_llm_registry.py
    • 226 passed
  • PYTHONPATH=. pytest -q tests/test_llm_service.py tests/test_llm_registry.py tests/test_api.py
    • 272 passed

The only reported warnings are existing Pydantic deprecation warnings.

Context

This PR is a fresh replacement for the previous llama.cpp provider PR, which was closed after its target branch was deleted. It is based on the current development branch as requested.

The benchmark work will be handled separately so the explicit provider implementation can be reviewed independently.

Copilot AI balanced review requested due to automatic review settings November 5, 2026 11:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@Abhishekpandey123-git

Copy link
Copy Markdown
Author

@marcvergees This PR addresses the explicit llama.cpp provider portion of #702.

The Ollama-vs-llama.cpp benchmark work will be handled separately so the provider implementation and benchmarking can be reviewed independently.

@vharkins1

Copy link
Copy Markdown
Collaborator

Thanks @Abhishekpandey123-git. A few notes on nice to haves you could add:

  • llama_cpp in contracts/schemas/enums.yaml
  • an entry in LLM_PROVIDER_ENV so it can actually be configured more easily

@marcvergees

Copy link
Copy Markdown
Member

Hi @Abhishekpandey123-git, Imma review this asap, but me and @vharkins1 are working rn on the desktop deployment, which is the most urgent thing rn because we might be onboarding again next week. I haven't forgot your stuff, don't worry!
M

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants