Templates: redesign to the v1 API contract + visual layout support - #596
Merged
marcvergees merged 7 commits intoAug 13, 2026
Merged
Conversation
chetanr25
force-pushed
the
template_registry
branch
3 times, most recently
from
June 27, 2026 19:35
0d0ef6f to
f188299
Compare
chetanr25
marked this pull request as ready for review
August 11, 2026 18:14
chetanr25
force-pushed
the
template_registry
branch
from
August 11, 2026 18:44
b20a677 to
697aa55
Compare
…type. Also drops leftover scratch files, a duplicated size guard, and an unused fixture.
marcvergees
merged commit Aug 13, 2026
849c219
into
fireform-core:development-approach-c
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Templates: redesign to the v1 API contract + visual layout support
Implements the whole templates layer from the contract: a registry keyed by
form_typeholding field definitions, where each value comes from, and where each field sits on the page. Form generation and extraction validation both read this shape.Closes #549. Also covers the field catalog and PDF flow from #609.
What this adds
source, which decides what else it needs:schemaneeds an incident mappingstaticneeds the text to printmanualneeds neither, a person types it per incidentopenneeds a description, which is the instruction the model getslayoutbox in PDF points, so the visual editor and the backend agree on coordinates.GET /schema/fieldsreturns every field in the incident contract with its path, type, aliases and PII flag. Built from the contract file itself, so it never drifts.Endpoints
/templates/templates/templates/{id}/templates/{id}/templates/{id}/fieldsrequired_only/templates/pdf/templates/pdf/{upload_id}/templates/{id}/pdf/schema/fieldsFix: #549
Part of: #541