This repository was archived by the owner on Feb 22, 2026. It is now read-only.
fix: unified exceptions and reactive pattern hardening#13
Merged
Conversation
@enable* annotations are designed to use @import — this is the correct Spring pattern (cf. @EnableScheduling, @EnableCaching, etc.). The anti-pattern we fixed was @import on @autoConfiguration classes. Restore @import(TransactionalEngineConfiguration.class) so the annotation works in both Spring Boot (auto-configuration) and plain Spring contexts (e.g. AnnotationConfigApplicationContext in tests). Conditional configs (persistence, Redis) remain in the .imports file.
TransactionalEngineConfiguration had a default InMemoryTccPersistenceProvider for TCC but no equivalent for Saga. When SagaPersistenceAutoConfiguration is not loaded (e.g. in plain Spring contexts via @EnableTransactionalEngine), SagaEngine creation fails due to missing SagaPersistenceProvider. Add a @ConditionalOnMissingBean default so the core configuration is self-contained, matching the existing TCC pattern.
…rationTest This test requires SagaPersistenceAutoConfiguration and SagaRedisAutoConfiguration for the SagaRecoveryService bean. Add explicit @import to match the pattern already used in SagaRecoveryIntegrationTest. Tests that need specific conditional configs should declare them explicitly rather than relying on @EnableTransactionalEngine to load everything transitively.
- Add fireflyframework-kernel dependency for unified exceptions - Fix fire-and-forget reactive patterns with error handlers - Standardize error handling across transactional flows
casc84ab
approved these changes
Feb 13, 2026
Contributor
casc84ab
left a comment
casc84ab
left a comment
There was a problem hiding this comment.
LGTM - Kernel dependency + reactive pattern hardening with proper error handlers on fire-and-forget chains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan