Multigrid: native transfers for non-Lagrange elements #4839
+390
−435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
force-pushed
the
pbrubeck/mg-quadrature
branch
2 times, most recently
from
5334c61 to
9cbefc7
Compare
pbrubeck
force-pushed
the
pbrubeck/mg-quadrature
branch
from
9cbefc7 to
0232cd8
Compare
pbrubeck
force-pushed
the
pbrubeck/mg-quadrature
branch
from
9c7ea3e to
806df32
Compare
pbrubeck
force-pushed
the
pbrubeck/mg-quadrature
branch
from
f20d778 to
6b0c385
Compare
pbrubeck
force-pushed
the
pbrubeck/mg-quadrature
branch
from
82b4277 to
8c52b0d
Compare
pbrubeck
force-pushed
the
pbrubeck/mg-quadrature
branch
2 times, most recently
from
35703d0 to
63272ae
Compare
pbrubeck
force-pushed
the
pbrubeck/mg-quadrature
branch
from
63272ae to
6cb4efe
Compare
pbrubeck
force-pushed
the
pbrubeck/mg-quadrature
branch
from
6cb4efe to
4b5cfa9
Compare
pbrubeck
changed the title
connorjward
requested changes
Jan 29, 2026
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
This is going to need a review from someone with more understanding of the FEM aspects of this.
pbrubeck
commented
Jan 29, 2026
pbrubeck
commented
Jan 29, 2026
pbrubeck
force-pushed
the
pbrubeck/mg-quadrature
branch
from
42d95d0 to
91839b9
Compare
dham
approved these changes
Jan 29, 2026
connorjward
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, multigrid on non-Lagrange elements relied on L2 projection onto an embedding DG space.
This PR implements a Quadrature space to remove the need for the L2 projection.
Here we reuse the codegen for interpolation into a
VertexOnlyMesh, namelycompile_expression_dual_evaluation, which supports interpolation across non-Lagrange elements (as long as the target element does not have derivative degrees of freedom). As a consequence,prolong,restrictandinjectare now natively able to transfer accrossFunctionSpaceson aMeshHierarchy, even for the case where the target and souce spaces are defined with different finite elements.