BDDC: cellwise subdomains, matfree MatIS, and user-defined primal vertices #4757
+214
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
reviewed
Dec 1, 2025
pbrubeck
force-pushed
the
pbrubeck/bddc-primal-vertices
branch
from
8414e2d to
29972f5
Compare
pbrubeck
force-pushed
the
pbrubeck/bddc-primal-vertices
branch
from
29972f5 to
9e69d99
Compare
pbrubeck
force-pushed
the
pbrubeck/bddc-primal-vertices
branch
from
868f5c8 to
af8b9e8
Compare
pbrubeck
force-pushed
the
pbrubeck/submesh-comm-self
branch
3 times, most recently
from
5d4cdbd to
34bad7b
Compare
pbrubeck
force-pushed
the
pbrubeck/submesh-comm-self
branch
from
34bad7b to
2df0024
Compare
pbrubeck
force-pushed
the
pbrubeck/bddc-primal-vertices
branch
from
ffca638 to
2f2e77d
Compare
pbrubeck
force-pushed
the
pbrubeck/submesh-comm-self
branch
from
363c075 to
9961010
Compare
pbrubeck
force-pushed
the
pbrubeck/submesh-comm-self
branch
from
9961010 to
825d2ef
Compare
pbrubeck
force-pushed
the
pbrubeck/bddc-primal-vertices
branch
from
119e9f2 to
d78a670
Compare
pbrubeck
commented
Dec 12, 2025
pbrubeck
commented
Dec 12, 2025
…roject/firedrake into pbrubeck/bddc-primal-vertices
Member
JHopeCollins
left a comment
JHopeCollins
left a comment
There was a problem hiding this comment.
Generally looks fine, I just have some small questions.
Comment on lines
+46
to
+49
| - ``'primal_markers'`` a Function marking degrees of freedom to be included in the | ||
| coarse space. If a DG(0) Function is provided, then all degrees of freedom on the cell | ||
| are marked as primal. Alternatively, primal_markers can be a list with the global | ||
| degrees of freedom to be included in the coarse space. |
Member
There was a problem hiding this comment.
Thanks for adding these to the docstring. I just have a couple of questions.
- Is this tested?
- The description of what the
Functioncan/should be is a bit unclear to me. What values should be in theDG(0)Function? Can I provide Functions in other spaces?
Comment on lines
72
to
73
| if variant == "fdm": | ||
| sp["mat_type"] = "matfree" |
Member
There was a problem hiding this comment.
Can this be included in the if-else blocks above? It's easier to read if the logic is together.
| assemblers.append(assembleP) | ||
|
|
||
| if P.type != "is": | ||
| raise ValueError(f"Expecting P to be either 'matfree' or 'is', not {P.type}.") |
Member
There was a problem hiding this comment.
Wouldn't this currently error even for P.type == "python"? Does that mean that the matfree branches aren't actually being tested?
Suggested change
| raise ValueError(f"Expecting P to be either 'matfree' or 'is', not {P.type}.") | |
| elif P.type != "is": | |
| raise ValueError(f"Expecting P to be either 'matfree' or 'is', not {P.type}.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds new features for BDDC.
-bddc_cellwiseenables cellwise subdomains.-bddc_matfreeenables a matfree MatIS to be used for the interior solver.appctx["primal_markers"].